fix(cli): fail video snapshots without FFmpeg#2302
Closed
miguel-heygen wants to merge 1 commit into
Closed
Conversation
Collaborator
Author
|
Consolidated with the related snapshot and frame diagnostics fixes in #2402, which preserves this PR’s behavior and regression coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Video-backed snapshots now fail with an actionable FFmpeg installation hint instead of succeeding with a black or blank video region when FFmpeg is unavailable.
Why
snapshotpreviously skipped frame extraction when it could not resolve FFmpeg, then silently fell through to Chrome's unreliable video seek path. On Windows environments without system FFmpeg this produced misleading black snapshots even though the command exited successfully.How
The video-frame extraction path now requires the resolved FFmpeg executable and surfaces the existing platform-specific installation guidance when it is missing. DOM-only snapshots are unchanged because the check runs only for active video extraction.
Test plan
bunx vitest run packages/cli/src/commands/snapshot.test.ts(14 passed)bun run build